Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Calibre's image actions to compress images in PRs #359

Closed
wants to merge 9 commits into from

Conversation

udbhavsomani
Copy link

Tested by adding 3 different types of images.

@udbhavsomani udbhavsomani changed the title Added Calibre's image actions to compress images in PRs - #353 Added Calibre's image actions to compress images in PRs Jan 2, 2023
Copy link
Contributor

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @udbhavsomani, added a couple of comments

jobs:
build:
# Only run on Pull Requests within the same repository, and not from forks.
# if: github.event.pull_request.head.repo.full_name == github.repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zerolab sure, I'll uncomment this, do you also want me to add cronjobs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thibaudcolas
Copy link
Member

@udbhavsomani thank you for giving this a go! I see there hasn’t been much movement on this in the last nine months, so I’ll close this now.

Personally I don’t think those kinds of GitHub Actions are a good idea at all, but that’s better discussed in #353.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants