-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Calibre's image actions to compress images in PRs #359
Conversation
testing compression complete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @udbhavsomani, added a couple of comments
jobs: | ||
build: | ||
# Only run on Pull Requests within the same repository, and not from forks. | ||
# if: github.event.pull_request.head.repo.full_name == github.repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed because of the limitations described in https://github.com/calibreapp/image-actions#process-pull-requests-from-forked-repositories
so https://github.com/calibreapp/image-actions#combined-workflow is probably the best
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zerolab sure, I'll uncomment this, do you also want me to add cronjobs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/calibreapp/image-actions#combined-workflow is the one that we want
Co-authored-by: Dan Braghis <[email protected]>
@udbhavsomani thank you for giving this a go! I see there hasn’t been much movement on this in the last nine months, so I’ll close this now. Personally I don’t think those kinds of GitHub Actions are a good idea at all, but that’s better discussed in #353. |
Tested by adding 3 different types of images.